-
Notifications
You must be signed in to change notification settings - Fork 6
added 2FJJMET analyser and stuff #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for this PR and I'm sorry for being very slow to take a look at it. I see there are very many scripts added and it's a bit hard to understand the bigger picture at first glance (and I'm not sure right now how much of the functionality in some of these scripts overlaps with existing functionality, and how much is orthogonal). So, I think it would be helpful if you could add a bit more text to the PR description, to list the main scripts that are added and what their main function is. I think this would help me to understand the PR a bit better. Thanks! |
|
the main change is to add the analysis_processor_2FJMET_fromNano into run_analysis step (to produce a hist.pkl), and make_plots (to produce plots etc. from the hist.pkl) for both step: for analysis processor: for make_plot |
.gitignore
Outdated
| .pytest_cache/ | ||
| cover/ | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this added line? It's usually best to avoid adding extraneous edits to files (as it can make the git history more confusing and less clean)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this copy needed? How does it differ from MET_basic.yaml? Also, avoid spaces in file names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the differences between this c2v2 yaml and the c2v1p5 yamls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test yaml needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? Also, if it's still being developed, maybe it should not be merged into the main yet.
analysis/vbs_vvh/run_analysis.py
Outdated
| LST_OF_KNOWN_PROCESSORS = ["semilep","semilep_nano","simple_gen",'2FJMET'] | ||
|
|
||
| import warnings | ||
| warnings.filterwarnings("ignore", message=".*as it is not interpretable by Uproot.*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What types of messages is this ignoring? Are we sure we want to ignore these?
removed extra lines
…ne in run_analysis
added 2fjmet analyzer and modified run_analysis to run 2fjmet
also added a couple of configs for managing the variables and cutflow